Skip to content

Skip graphql schema check in forks#7466

Merged
gonzaloriestra merged 1 commit intomainfrom
skip-graphql-schema-check-in-forks
May 5, 2026
Merged

Skip graphql schema check in forks#7466
gonzaloriestra merged 1 commit intomainfrom
skip-graphql-schema-check-in-forks

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The Check graphql-codegen has been run job relies on GH secrets to fetch internal schemas. GitHub does not expose secrets to workflows triggered from forks, so the job fails with auth errors on every fork PR — the same reason dependabot[bot] PRs are already skipped.

Example: #7436

WHAT is this pull request doing?

Skip the job on PRs from forks, while still running for merge_group events (where the merge queue runs from the base repo and secrets are available).

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 5, 2026 09:45
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 5, 2026
@gonzaloriestra gonzaloriestra temporarily deployed to breaking-change-approval May 5, 2026 09:46 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.

💬 Head to #help-dev-platform to discuss timing and plan the release.

📝 Removed Schema Fields

The following Zod schema fields were removed or their files deleted:

File Removed Fields Reason
packages/app/src/cli/models/extensions/specifications/type-generation.ts value Fields removed

@gonzaloriestra gonzaloriestra temporarily deployed to breaking-change-approval May 5, 2026 10:04 — with GitHub Actions Inactive
@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit bafe6e4 May 5, 2026
48 of 54 checks passed
@gonzaloriestra gonzaloriestra deleted the skip-graphql-schema-check-in-forks branch May 5, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants