Remove dead shouldIgnoreEvent filter from file watcher#7492
Draft
isaacroldan wants to merge 1 commit intofile-watcher-detect-new-filesfrom
Draft
Remove dead shouldIgnoreEvent filter from file watcher#7492isaacroldan wants to merge 1 commit intofile-watcher-detect-new-filesfrom
isaacroldan wants to merge 1 commit intofile-watcher-detect-new-filesfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
4 tasks
isaacroldan
force-pushed
the
remove-file-watcher-dead-code
branch
from
6f9fc37 to
8e6d25a
Compare
shouldIgnoreEvent always returned false for any event that reached it: - extension_folder_* events short-circuited at the first line. - The literal-list check (watchPaths.some(matchGlob)) was always true, because pushEvent was only ever called for paths that came from extensionWatchedFiles, which is itself built from watchedFiles(). - The else-if gitignore branch was unreachable: watchedFiles() always returns a (possibly empty) array, so watchPaths is always truthy. Filtering for unknown paths happens earlier in handleFileEvent's 'not watched by any extension' early return; shouldIgnoreEvent was never doing real work. Deletes the method, the `ignored` field and createIgnoreInstance helper, the extension_folder_created branch in pushEvent (its only job was to populate `ignored`), the updateApp ignore-population, and the dynamic-map short-circuit added in the parent PR (now redundant).
isaacroldan
force-pushed
the
remove-file-watcher-dead-code
branch
from
8e6d25a to
c17d3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add