Skip to content

Remove deprecated shopify theme serve command#7527

Open
alfonso-noriega wants to merge 1 commit into07-remove-top-level-webhook-trigger-aliasfrom
08-remove-theme-serve-command
Open

Remove deprecated shopify theme serve command#7527
alfonso-noriega wants to merge 1 commit into07-remove-top-level-webhook-trigger-aliasfrom
08-remove-theme-serve-command

Conversation

@alfonso-noriega
Copy link
Copy Markdown
Contributor

@alfonso-noriega alfonso-noriega commented May 11, 2026

WHY are these changes introduced?

The shopify theme serve command was a hidden alias for shopify theme dev. It rendered a "shopify theme serve" command is deprecated warning and forwarded the call. This PR removes the deprecated alias in preparation for the next major release.

This is the last PR in the deprecated-flag-removal stack: #7526 ← this PR. (Theme-related changes are intentionally placed at the end of the stack.)

WHAT is this pull request doing?

  • Deletes packages/theme/src/cli/commands/theme/serve.ts (the Serve class).
  • Removes the import and the 'theme:serve' entry from packages/theme/src/index.ts.
  • Regenerates packages/cli/oclif.manifest.json (the entry is removed from the manifest).
  • The supported shopify theme dev command (and its tests) are unchanged.

How to test your changes?

  1. Run pnpm shopify theme serve --help and confirm it now fails with Command theme:serve not found.
  2. Run pnpm shopify theme dev --help and confirm the supported command still works.
  3. Run pnpm shopify theme dev against a theme and confirm the local dev server starts as before.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

alfonso-noriega commented May 11, 2026

@github-actions github-actions Bot added the Area: @shopify/theme @shopify/theme package issues label May 11, 2026
@alfonso-noriega alfonso-noriega temporarily deployed to breaking-change-approval May 11, 2026 12:35 — with GitHub Actions Inactive
The hidden `shopify theme serve` command was a deprecated alias for
`shopify theme dev` that printed a warning and forwarded the call.
This change deletes the alias class and unregisters it from the theme
command map.
@alfonso-noriega alfonso-noriega force-pushed the 08-remove-theme-serve-command branch from 0fcac12 to a960ee9 Compare May 11, 2026 12:52
@alfonso-noriega alfonso-noriega force-pushed the 07-remove-top-level-webhook-trigger-alias branch from f964ab1 to 60d2697 Compare May 11, 2026 12:52
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.

💬 Head to #help-dev-platform to discuss timing and plan the release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
remove-app-deploy-force-flag.md '@shopify/app': major
remove-app-generate-extension-type-flag.md '@shopify/app': major
remove-app-generate-schema-command.md '@shopify/app': major
remove-app-release-force-flag.md '@shopify/app': major
remove-app-scaffold-extension-command.md '@shopify/app': major
remove-theme-serve-command.md '@shopify/theme': major
remove-top-level-webhook-trigger-alias.md '@shopify/app': major
remove-webhook-trigger-shared-secret-flag.md '@shopify/app': major
thin-webs-notice.md '@shopify/plugin-did-you-mean': major
thin-webs-notice.md '@shopify/plugin-cloudflare': major
thin-webs-notice.md '@shopify/create-app': major
thin-webs-notice.md '@shopify/cli-kit': major
thin-webs-notice.md '@shopify/store': major
thin-webs-notice.md '@shopify/theme': major
thin-webs-notice.md '@shopify/app': major
thin-webs-notice.md '@shopify/cli': major
thin-webs-notice.md '@shopify/e2e': major

🗑️ Removed Commands

The following commands were removed from the OCLIF manifest:

  • theme:serve

@alfonso-noriega alfonso-noriega temporarily deployed to breaking-change-approval May 11, 2026 12:53 — with GitHub Actions Inactive
@alfonso-noriega alfonso-noriega marked this pull request as ready for review May 11, 2026 15:15
@alfonso-noriega alfonso-noriega requested review from a team as code owners May 11, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/theme @shopify/theme package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants