Skip to content

[Refactor] Use uniq helper in store auth scopes#7638

Merged
gonzaloriestra merged 1 commit into
mainfrom
refactor-use-uniq-in-store-scopes-8495668938836215213
Jun 1, 2026
Merged

[Refactor] Use uniq helper in store auth scopes#7638
gonzaloriestra merged 1 commit into
mainfrom
refactor-use-uniq-in-store-scopes-8495668938836215213

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented May 26, 2026

WHY are these changes introduced?

Follows the repository's preference for using the uniq utility from @shopify/cli-kit instead of manual Set spreads for array deduplication.

WHAT is this pull request doing?

Replaces [...new Set(scopes)] with uniq(scopes) in packages/store/src/cli/services/store/auth/scopes.ts.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 8495668938836215213 started by @gonzaloriestra

Replaces manual array deduplication using Set spreads with the `uniq`
helper from `@shopify/cli-kit/common/array` for better consistency
and readability.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 26, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 26, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 26, 2026 08:48
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 26, 2026 08:48
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit da83a9e Jun 1, 2026
30 checks passed
@gonzaloriestra gonzaloriestra deleted the refactor-use-uniq-in-store-scopes-8495668938836215213 branch June 1, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants