Skip to content

Fix config link from extension directories#8006

Merged
isaacroldan merged 2 commits into
mainfrom
fix-config-link-from-extension-dir
Jul 6, 2026
Merged

Fix config link from extension directories#8006
isaacroldan merged 2 commits into
mainfrom
fix-config-link-from-extension-dir

Conversation

@isaacroldan

Copy link
Copy Markdown
Contributor

Why

Running shopify app config link from an extension directory could scan the extension folder for app TOMLs, decide none existed, and overwrite the root shopify.app.toml when creating a new linked app.

What

  • Use the resolved app root when choosing the config filename.
  • Preserve the root prompt behavior when existing app TOMLs are present.
  • Add regression coverage for linking a new app from an extension directory.

Testing

  • pnpm vitest run packages/app/src/cli/services/app/config/link.test.ts

Assisted-By: devx/60f87861-3b15-4c10-b879-f284b3a36465
@isaacroldan isaacroldan requested review from a team as code owners July 6, 2026 09:57
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Jul 6, 2026
@isaacroldan isaacroldan merged commit 00e3ecd into main Jul 6, 2026
29 checks passed
@isaacroldan isaacroldan deleted the fix-config-link-from-extension-dir branch July 6, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants