Merged
Conversation
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
This also removed the deprecated behavior of setting the behavior of the ActiveSupport::Deprecation singleton. Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
adrianna-chang-shopify
approved these changes
Nov 17, 2023
| with_rails_70_app do | ||
| behavior = ActiveSupport::Deprecation::DEFAULT_BEHAVIORS[:notify] | ||
|
|
||
| DeprecationToolkit::RSpecPlugin.before_suite |
Contributor
There was a problem hiding this comment.
Wondering if we should move this to the with_rails_70_app helper actually? 🤔
Member
Author
There was a problem hiding this comment.
I like having the test itself doing the exercise step if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot a few in #90, this removes them.
I also had to bring the new "fake Rails 7.1 app" setup so that we wouldn't call the deprecated behavior. And similarly kept the tests testing that behavior but only when not running Active Support >= 7.1.
We paired with @adrianna-chang-shopify on this. We had to extract the RSpec plugin setup so that we could call it and check its behavior, previously the plugin specs were not exercising anything, just asserting that the behavior had happened while booting the spec suite.
Also CI was mistakenly configured where it was testing 7.1 with
gemfiles/activesupport_7.0.gemfileGemfile. And we were not testing withGemfiledirectly.