Allow configuration of minitest file paths and file names#95
Merged
stephsachrajda merged 2 commits intomainfrom Jan 15, 2024
Merged
Allow configuration of minitest file paths and file names#95stephsachrajda merged 2 commits intomainfrom
stephsachrajda merged 2 commits intomainfrom
Conversation
As discussed in person, I would be in favour of this so we can leave the old behaviour (or at least make it possible to restore the old behaviour). |
stephsachrajda
force-pushed
the
ssach/use-file-path
branch
4 times, most recently
from
0738865 to
db7d784
Compare
stephsachrajda
changed the title
stephsachrajda
force-pushed
the
ssach/use-file-path
branch
5 times, most recently
from
432c15b to
16619ae
Compare
rafaelfranca
approved these changes
Jan 11, 2024
stephsachrajda
force-pushed
the
ssach/use-file-path
branch
from
16619ae to
f8f360e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, deprecation toolkit uses
class.name.underscoreto name the files where it stores the deprecations, which works well in most cases, but means that in the case of subclasses in test files (or typos), the actual files containing the deprecations are hard to find.The Change
This allows the user to configure the file path/name format for their setup. It would allow folks to use the full file paths if that's easier for them and customize in any way that suits while maintaining the current behaviour as the default.