Fix order routing location rule extension template#282
Merged
vividviolet merged 1 commit intomainfrom Jul 4, 2025
Merged
Conversation
4be461c to
0c7277a
Compare
jbalsas
approved these changes
Jul 4, 2025
Member
jbalsas
left a comment
There was a problem hiding this comment.
Couldn't 🎩 because CLI kept refusing to log me in with the right organization, but changes make sense to me, I think!
0c7277a to
9ca0859
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Background
This PR put back support for different React, and vanilla JS in the OrderRoutingLocationRule template.
Testing
shopify app generate extension --clone-url https://github.com/Shopify/extensions-templates#Fix_Order_Routing_Location_Rule_extension_templateChecklist