Skip to content

Fix order routing location rule extension template#282

Merged
vividviolet merged 1 commit intomainfrom
Fix_Order_Routing_Location_Rule_extension_template
Jul 4, 2025
Merged

Fix order routing location rule extension template#282
vividviolet merged 1 commit intomainfrom
Fix_Order_Routing_Location_Rule_extension_template

Conversation

@vividviolet
Copy link
Member

@vividviolet vividviolet commented Jul 3, 2025

Background

This PR put back support for different React, and vanilla JS in the OrderRoutingLocationRule template.

Testing

  1. Run shopify app generate extension --clone-url https://github.com/Shopify/extensions-templates#Fix_Order_Routing_Location_Rule_extension_template
  2. Verify you can generate an "Order routing location rule - UI Extension"

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vividviolet vividviolet marked this pull request as ready for review July 3, 2025 17:02
@vividviolet vividviolet force-pushed the Fix_Order_Routing_Location_Rule_extension_template branch from 4be461c to 0c7277a Compare July 3, 2025 17:38
@vividviolet vividviolet requested a review from jbalsas July 3, 2025 17:39
Copy link
Member

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't 🎩 because CLI kept refusing to log me in with the right organization, but changes make sense to me, I think!

@vividviolet vividviolet force-pushed the Fix_Order_Routing_Location_Rule_extension_template branch from 0c7277a to 9ca0859 Compare July 4, 2025 13:50
Copy link
Member Author

vividviolet commented Jul 4, 2025

Merge activity

  • Jul 4, 4:22 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 4, 4:22 PM UTC: @vividviolet merged this pull request with Graphite.

@vividviolet vividviolet merged commit 71e1b03 into main Jul 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants