Fix index out of bounds in viewability computation#2087
Merged
naqvitalha merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
The previous implementation of recomputeViewableItems() would clear the last reported viewable indices and then immediately call updateViewableItems(), which could use stale or invalid indices leading to index out of bounds errors. This fix separates the operations: 1. Clear the last reported viewable indices 2. Call computeItemViewability() which properly computes fresh visible indices before updating viewable items This ensures the indices are always freshly computed from the current state before being used, preventing index out of bounds errors.
tmgsca
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an index out of bounds error in viewability computation.
Problem
The previous implementation of
recomputeViewableItems()would:updateViewableItems()This could use stale or invalid indices leading to index out of bounds errors when the data has changed.
Solution
This fix separates the operations in
RecyclerViewManager.recomputeViewableItems():clearLastReportedViewableIndices()computeItemViewability()which properly computes fresh visible indices before updating viewable itemsThis ensures the indices are always freshly computed from the current state before being used, preventing index out of bounds errors.
Changes
ViewabilityManager.recomputeViewableItems()renamed toclearLastReportedViewableIndices()and simplified to only clear indicesRecyclerViewManager.recomputeViewableItems()now callsclearLastReportedViewableIndices()followed bycomputeItemViewability()