chore: update skills with testing methodology learnings#2113
Merged
naqvitalha merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
- Add "dist/ not rebuilt on branch switch" pitfall - Add "always reproduce before verifying fix" methodology - Add visible counter technique for testing callbacks - Add masonry sorting performance warning
naqvitalha
force-pushed
the
chore/update-skills-learnings
branch
from
bbd2eb4 to
ed6c824
Compare
gantonious
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
review-and-testandfix-github-issueskills with learnings from recent PR review sessions.Key additions:
dist/is not rebuilt on branch switch — mustyarn buildafter everygit checkoutand verify withgrepin distmainfirst, then verify on the PR branchonStartReachedArray.sort()in scroll-path code as a performance concernTest plan