Skip to content

chore: update skill instructions for metro port, app install, and e2e#2132

Merged
naqvitalha merged 1 commit intomainfrom
chore/update-skill-instructions
Mar 4, 2026
Merged

chore: update skill instructions for metro port, app install, and e2e#2132
naqvitalha merged 1 commit intomainfrom
chore/update-skill-instructions

Conversation

@naqvitalha
Copy link
Collaborator

Description

Updates the fix-github-issue and review-and-test skill files with three improvements:

  1. Metro port 8087 — all references updated from 8081 to 8087 to match actual dev setup
  2. Skip native build if app installed — checks xcrun simctl get_app_container before running run-ios, avoiding unnecessary rebuilds
  3. E2e test enforcement — when e2e test files (*.e2e.*) are added or modified, they must be run and pass before raising a PR
  4. Metro connection troubleshooting — added fallback tip to configure bundler port via Dev Menu if app can't connect

Also simplified the Metro section in fix-github-issue to remove redundant setup instructions.

Reviewers' hat-rack 🎩

These are internal skill files (.claude/skills/). No runtime code changes.

Test plan

  • Read through both updated skill files for accuracy
  • Verify port 8087 is consistent across all references

…nd e2e tests

- Use metro port 8087 instead of 8081
- Only build native app if not already installed on simulator
- Require e2e tests to pass when e2e test files are added/modified
- Add troubleshooting tip for app-to-metro connection issues
@naqvitalha naqvitalha requested a review from tmgsca March 4, 2026 18:03
@naqvitalha naqvitalha merged commit e81f4ef into main Mar 4, 2026
18 of 20 checks passed
@naqvitalha naqvitalha deleted the chore/update-skill-instructions branch March 4, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants