chore(ci): strengthen AGENT_PR_TOKEN usage in raise-pr skill#2198
Closed
naqvitalha wants to merge 1 commit intomainfrom
Closed
chore(ci): strengthen AGENT_PR_TOKEN usage in raise-pr skill#2198naqvitalha wants to merge 1 commit intomainfrom
naqvitalha wants to merge 1 commit intomainfrom
Conversation
Add token verification step and fallback to prevent PRs being created with the wrong token (default GITHUB_TOKEN shows as app/github-actions and can't be merged). Adds post-creation author check.
Collaborator
Author
|
Superseded by #2200 (combined PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strengthen the
AGENT_PR_TOKENinstructions in the raise-pr skill to prevent agents from creating PRs with the wrong token. In a recent run (Agent Fix #23455139708), the agent created PR #2196 asapp/github-actionsinstead of usingAGENT_PR_TOKEN, making it unmergeable.Adds a pre-flight token verification step, a fallback to
SHOPIFY_GH_ACCESS_TOKEN, and a post-creation author check.Reviewers' hat-rack 🎩
Check that the blockquote instructions are clear and unambiguous — this needs to be impossible for the agent to skip.
Test plan
app/github-actions)