Skip to content

chore(ci): fix agent-fix issue targeting and PR token usage #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naqvitalha merged 2 commits into from
Mar 23, 2026
Merged

chore(ci): fix agent-fix issue targeting and PR token usage #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651ce63
chore(ci): strengthen AGENT_PR_TOKEN usage in raise-pr skill
naqvitalha Mar 23, 2026
295287e
chore(ci): pass explicit issue number to agent-fix prompt
naqvitalha Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .claude/skills/raise-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,17 @@ GH_TOKEN="$AGENT_PR_TOKEN" gh pr create \
--body-file /tmp/pr-body.md
```

**MANDATORY:** The `GH_TOKEN="$AGENT_PR_TOKEN"` prefix is required. PRs created without it cannot be merged. On CI, `AGENT_PR_TOKEN` is set automatically from `SHOPIFY_GH_ACCESS_TOKEN`. Locally, ensure it is exported or pass your token directly.
> **CRITICAL — TOKEN VERIFICATION (read this before running `gh pr create`)**
>
> 1. First, verify the token is available: `[ -n "$AGENT_PR_TOKEN" ] && echo "token ok" || echo "TOKEN MISSING"` — do NOT echo the token value itself.
> 2. You **MUST** use `GH_TOKEN="$AGENT_PR_TOKEN" gh pr create ...` — never bare `gh pr create`.
> 3. PRs created with the default `GITHUB_TOKEN` show as `app/github-actions` and **cannot be merged**.
> 4. After creating the PR, verify the author: `gh pr view --json author --jq '.author.login'` — it must NOT be `app/github-actions`.
>
> If `AGENT_PR_TOKEN` is empty, try `SHOPIFY_GH_ACCESS_TOKEN` as fallback: `GH_TOKEN="${AGENT_PR_TOKEN:-$SHOPIFY_GH_ACCESS_TOKEN}" gh pr create ...`

Before running `gh pr create`, double-check:
- [ ] Token is verified (see above)
- [ ] No mention of Claude, AI, Anthropic, or any AI tool anywhere
- [ ] Description explains the "what" and "why" clearly
- [ ] Test plan is specific to the change
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/agent-fix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ jobs:
prompt: |
You are running on CI (GitHub Actions). There is no human to confirm with — act autonomously.
Environment: macOS runner with Xcode and iOS simulator. No Android emulator.
Fix this GitHub issue. Read and follow .claude/skills/fix-github-issue/SKILL.md for the full workflow.

YOUR ASSIGNED ISSUE: #${{ github.event.issue.number }}
TITLE: ${{ github.event.issue.title }}

Fix ONLY this issue — do not fix other issues. Read and follow .claude/skills/fix-github-issue/SKILL.md for the full workflow.
After fixing, read and follow .claude/skills/raise-pr/SKILL.md to raise a PR.
CI notes: use default Metro port (8081).

Expand Down
Loading