JSON output using the --json flag#20
Merged
hainsdominic merged 4 commits intomainfrom Jun 1, 2022
Merged
Conversation
Contributor
|
Make sure to set the base branch to what you based this one off of- right now the diff shows everything in the chain of PRs |
Contributor
Author
Fixed it, thanks for the heads up |
DuncanUszkay1
approved these changes
May 31, 2022
andrewhassan
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12
What are you trying to accomplish?
The logs can be displayed in the JSON format using the
--jsonflag while using the CLI.The impact of these changes
On Shopify
Shopify can gather these logs and process them.
On merchants
No change
On third-party apps
The 3rd party developer can pipe the output into a json file to analyze their scripts at a larger scale.
Tophat 🎩
You can test your own script by running
cargo run --release -- --json <path/to/input.json> -s <path/to/script.wasm>.Before you deploy