Skip to content

Adding fuel consumed and ability to run with javy provider#65

Merged
dwdking merged 3 commits intomainfrom
dwdking/javy-provider
Mar 6, 2023
Merged

Adding fuel consumed and ability to run with javy provider#65
dwdking merged 3 commits intomainfrom
dwdking/javy-provider

Conversation

@dwdking
Copy link
Copy Markdown
Contributor

@dwdking dwdking commented Mar 1, 2023

This PR does two things.

  1. Adds the javy provider and automatically links to it when a function being executed requires javy.
  2. Adds fuel reporting to the output, currently hardcoding a u64::MAX as the fuel amount

@dwdking dwdking force-pushed the dwdking/javy-provider branch 3 times, most recently from 60b27de to e422aca Compare March 2, 2023 14:13
@dwdking dwdking requested a review from mkcny March 2, 2023 14:18
@dwdking dwdking marked this pull request as ready for review March 2, 2023 14:18
@dwdking dwdking requested a review from makrisoft March 2, 2023 14:22
@nickwesselman
Copy link
Copy Markdown

Instead of "fuel burned" I'd suggest we use the "instruction" nomenclature right away, perhaps divided by 1000 to make the number a bit more digestable. e.g.

Instructions: 502K

Any opinions on this @davejcameron?

@dwdking dwdking force-pushed the dwdking/javy-provider branch from e422aca to 2542317 Compare March 3, 2023 17:09
@dwdking dwdking changed the title Adding fuel consume and ability to run with javy provider Adding fuel consumed and ability to run with javy provider Mar 3, 2023
@dwdking dwdking force-pushed the dwdking/javy-provider branch from 2542317 to c6762da Compare March 3, 2023 17:22
@dwdking dwdking force-pushed the dwdking/javy-provider branch from c6762da to 5539cb2 Compare March 3, 2023 18:06
Comment thread src/engine.rs
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/function_run_result.rs Outdated
@dwdking dwdking merged commit b5ad51e into main Mar 6, 2023
@dwdking dwdking deleted the dwdking/javy-provider branch March 6, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants