Conversation
|
🤖 Code Review · Skipped — PR has too many files for review (limit: 1000) |
driv3r
force-pushed
the
get-rid-of-vendored-packages
branch
from
f12994a to
0dc9503
Compare
austenLacy
reviewed
Apr 14, 2026
austenLacy
left a comment
austenLacy
left a comment
There was a problem hiding this comment.
do we not need to update anything in go.mod?
Contributor
Author
|
@austenLacy no, it gets picked up by |
austenLacy
approved these changes
Apr 15, 2026
RuntimeError: could not compile ghostferry only shows the Ruby-level failure; the underlying go build error is lost. This makes it impossible to diagnose CI failures like 'inconsistent vendoring' from the test log alone. - Replace system() with Open3.capture2e so go build stderr is captured. - Include the captured output in the raised error message. - Before each build, log GOMOD / GOWORK / GOFLAGS and whether vendor/modules.txt is present in the repo root, to pinpoint unexpected workspace or vendor-mode activation.
actions/checkout does not always remove previously-tracked files that were deleted in a later commit. A runner that checked out a commit with vendor/ and then checks out a commit without it may still find vendor/ on disk, causing Go to auto-activate vendor mode and fail with 'inconsistent vendoring'. Add GOFLAGS=-mod=mod at workflow level so all jobs explicitly use module mode regardless of whether a stale vendor/ directory exists on disk. Also fix an off-by-one in the compile_binary diagnostic: repo_root was computed 3 levels up from test/helpers/ (reaching the parent of the repo) instead of 2 levels up (the repo root itself), causing the vendor/modules.txt presence check to report a false negative.
The go env / vendor/modules.txt diagnostic lines added in the previous commit have served their purpose. Retain the Open3.capture2e change so that go build errors remain visible in the test failure message.
driv3r
force-pushed
the
get-rid-of-vendored-packages
branch
from
3cd3fd2 to
fb0ca17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should streamline updates and reduce the noise in PRs