Add support for publishing to Maven Central#57
Merged
Conversation
9cf509b to
0391bd5
Compare
Contributor
|
Thanks for doing this migration! Although, I don't think I am the best to review the code changes |
Member
|
Code looks good but it looks like the readme is still referencing jcenter at the bottom of the installation section. Probably a good opportunity to modernize the gradle snippet from using |
gantonious
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JFrog has shutdown Bintray and JCenter. See announcement here.
This PR removes the Bintray plugin and adds a GitHub action for automated publishing to OSSRH staging repository (promotion to Maven Central will require manual confirmation).
I've also bumped the patch version to reflect this is a rebuild of
0.2.0but hosted on a new repository.See https://github.com/Shopify/graphql_java_gen/runs/2464072449?check_suite_focus=true for an example of the Github action in... action.