Skip to content

Move arg helpers to WithArgs module.#15

Merged
cocoahero merged 1 commit intomasterfrom
directive-arg-helpers
Jun 8, 2021
Merged

Move arg helpers to WithArgs module.#15
cocoahero merged 1 commit intomasterfrom
directive-arg-helpers

Conversation

@cocoahero
Copy link
Copy Markdown
Contributor

@cocoahero cocoahero commented Jun 8, 2021 •
edited
Loading

Extracts the helpful required_args and optional_args methods to the WithArgs module for use with directives.

@cocoahero cocoahero requested review from aaackerman and eapache June 8, 2021 18:28
@cocoahero cocoahero self-assigned this Jun 8, 2021
@cocoahero cocoahero requested a review from swalkinshaw June 8, 2021 18:41
aaackerman
aaackerman approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aaackerman aaackerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this 👍

@cocoahero cocoahero merged commit b51b66e into master Jun 8, 2021
@cocoahero cocoahero deleted the directive-arg-helpers branch June 8, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaackerman aaackerman aaackerman approved these changes

@eapache eapache Awaiting requested review from eapache

@swalkinshaw swalkinshaw Awaiting requested review from swalkinshaw

Assignees

@cocoahero cocoahero

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cocoahero @aaackerman