Conversation
| end | ||
|
|
||
| def field_from_name(field_name, include_deprecated: false) | ||
| @fields_by_name ||= fields(include_deprecated: include_deprecated).map{ |field| [field.name, field]}.to_h |
Contributor
There was a problem hiding this comment.
This will memoize the hash based on the include_deprecated value of the first call and ignore it on subsequent calls.
Contributor
Author
There was a problem hiding this comment.
Maybe this should just be.
def fields_by_name
@fields_by_name ||= fields(include_deprecated: true).map{ |field| [field.name, field]}.to_h
end
And then the user can check later if the field is deprecated.
swalkinshaw
approved these changes
Mar 21, 2017
dylanahsmith
approved these changes
Mar 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
field_from_nameontoTypeDefinition.I don't like how
include_deprecatedis handled but I'm not sure there's a nicer way to handle it.