Use shop.primaryDomain to mark internal links in demo store#1036
Merged
blittle merged 4 commits intoShopify:2023-04from Jun 28, 2023
Merged
Use shop.primaryDomain to mark internal links in demo store#1036blittle merged 4 commits intoShopify:2023-04from
shop.primaryDomain to mark internal links in demo store#1036blittle merged 4 commits intoShopify:2023-04from
Conversation
Contributor
blittle
approved these changes
Jun 27, 2023
Contributor
blittle
left a comment
blittle
left a comment
There was a problem hiding this comment.
Thank you for submitting this!
Closed
juanpprieto
pushed a commit
that referenced
this pull request
Jul 10, 2023
Use shop.primaryDomain to mark internal links --------- Co-authored-by: Bret Little <bret.little@shopify.com>
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
…y#1036) Use shop.primaryDomain to mark internal links --------- Co-authored-by: Bret Little <bret.little@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1035
WHAT is this pull request doing?
Checking if the nav item url host matches the
shop.primaryDomain's host, and marks the nav item as internal if so. Previously it was a simple regex.HOW to test your changes?
Spin up the demo store and see that the nav links are indeed internal.
Checklist