Skip to content

Fix cart and revert client-side render workaround on demo-store#1085

Merged
wizardlyhel merged 4 commits into2023-04from
fix-cart
Jul 7, 2023
Merged

Fix cart and revert client-side render workaround on demo-store#1085
wizardlyhel merged 4 commits into2023-04from
fix-cart

Conversation

@wizardlyhel
Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@wizardlyhel wizardlyhel merged commit 90e26dc into 2023-04 Jul 7, 2023
@wizardlyhel wizardlyhel deleted the fix-cart branch July 7, 2023 20:34
juanpprieto pushed a commit that referenced this pull request Jul 10, 2023
* Revert client-side render with proper cart fix
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
kdaviduik added a commit that referenced this pull request Mar 6, 2026
Confirmed all GitHub API calls work via live test (issues #1084, #1085, #1086 in Shopify/developer-tools-team).

Changes:
- Replace all HEREDOC patterns with Write tool + --body-file (HEREDOC blocked in sandbox)
- Add Status field mutation alongside Project field in all three code paths (Step 7a, Step 8d, setup_phase_child_issue function)
- Add Status verification to all three code paths and to Checkpoint 3
- Document 'child' label pre-exists (no creation needed)
- Add Success Criteria Checklist section
- Add new project constants: Status field ID (PVTSSF_lADNH5XOABDyGM4AnCva) and Todo-prioritized option ID (f75ad846)
- Add Lesson 6: HEREDOC blocked in sandbox
- Add Lesson 7: GraphQL variable interpolation with '"ENV_VAR"' pattern
- Fix literal <PARENT_NUM> placeholders in Step 8e GraphQL queries (bug: they weren't expanding)
- Save PARENT_NUM to /tmp/claude/parent_num.txt for cross-step recovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants