Remove deprecated --worker CLI flag#2603
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
| preview: Flags.boolean({ | ||
| description: | ||
| 'Deploys to the Preview environment. Overrides --env-branch and Git metadata.', | ||
| 'Deploys to the Preview environment. Overrides Git metadata.', |
There was a problem hiding this comment.
This previously stated that it Overrides --env-branch, but looking at the original code in this file a little further down it appears that this wasn't actually the case (and I think we should also remove the claim that this overrides the Git metadata too?)
There was a problem hiding this comment.
yes - remove --env-branch comment
overrides Git metadata - @frandiox Does hydrogen deploy preview actually overrides git metadata? I don't see its doing that in code either. Running npx shopify hydrogen deploy --preview just creates a preview deploy with no changes to user's repo (which is expected). I think the metadata here is referring to oxygen specific metadata.
There was a problem hiding this comment.
I've reverted the removal of the flag, but I think this update should remain as the code shows that this claim was false anyway
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@shopify/cli-hydrogen': patch | |||
There was a problem hiding this comment.
@frandiox Should this be a major bump?
There was a problem hiding this comment.
Technically yes, but since we are releasing under the bundled global CLI, it doesn't matter much. It's not going to be a major bump in the bundled CLI yet, so feel free to do it in a minor here. It's also been announced as deprecated for very long so it's probably OK.
wizardlyhel
left a comment
wizardlyhel
left a comment
There was a problem hiding this comment.
Gonna need to revert the changes to --env-branch and leave it in the deprecated state. It can only be remove once --env is supported in CI. Details https://github.com/Shopify/custom-storefronts/issues/560
rbshop
changed the title
|
I have now reverted the |
Co-authored-by: Helen Lin <helen.lin@shopify.com>
3 participants
WHY are these changes introduced?
This flag has been deprecated for a while and is due to be removed with the next release
WHAT is this pull request doing?
--workerflagChecklist