fix(skeleton): remove dead gift card client-side state tracking #3426
+2
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
5 tasks
fredericoo
force-pushed
the
kd-gift-cards-e2e
branch
from
d7e2cc3 to
ba7a43d
Compare
The CartGiftCard component maintained a useRef that accumulated gift card codes client-side, but this ref was never read - only written to. This created potential for "zombie" bugs where the client and server state could diverge (the ref only grew, never shrunk when cards were removed). Since the GiftCardCodesAdd action handles everything server-side and the UI displays gift cards directly from the GraphQL response (cart.appliedGiftCards), this client-side tracking was redundant and potentially problematic. Removed: - appliedGiftCardCodes useRef (dead code - write-only) - saveAppliedCode function (populated unused ref) - Render-prop pattern with side effects in AddGiftCardForm - Unused FetcherWithComponents import
fredericoo
force-pushed
the
kd-fix-gift-card-resurrection-bug
branch
from
c79dc17 to
64be556
Compare
fredericoo
reviewed
Jan 29, 2026
Comment on lines
115
to
119
| useEffect(() => { | ||
| if (giftCardAddFetcher.data) { | ||
| giftCardCodeInput.current!.value = ''; | ||
| } | ||
| }, [giftCardAddFetcher.data]); |
Contributor
There was a problem hiding this comment.
im not a fan of this either but i guess there aren’t callbacks for fetcher to reset the form
we could pass a ref to the form and call form.reset() that would give me some peace of mind but overall they do the same so whatever, lets not change for the sake of changing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CartGiftCard component maintained a useRef that accumulated gift card codes client-side, but this ref was never read - only written to. This created potential for "zombie" bugs where the client and server state could diverge (the ref only grew, never shrunk when cards were removed).
Since the GiftCardCodesAdd action handles everything server-side and the UI displays gift cards directly from the GraphQL response (cart.appliedGiftCards), this client-side tracking was redundant and potentially problematic.
Removed:
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist