Skip to content

fix: removes rr7 warn on dev.ts#3499

Merged
andguy95 merged 2 commits intomainfrom
an-removes-rr7-warn
Feb 25, 2026
Merged

fix: removes rr7 warn on dev.ts#3499
andguy95 merged 2 commits intomainfrom
an-removes-rr7-warn

Conversation

@andguy95
Copy link
Collaborator

WHY are these changes introduced?

The React Router v7 version check was generating inaccurate warnings during shopify hydrogen dev because it was not correctly checking what was actually resolved in node_modules. This caused confusion for developers who had valid React Router installations but were still seeing version mismatch warnings.

WHAT is this pull request doing?

Removes the React Router v7 version compatibility check from the Hydrogen dev command:

  • Deletes packages/cli/src/lib/react-router-version-check.ts — the utility that compared RR7 package versions against an expected 7.12.0 baseline
  • Removes the checkReactRouterVersions() call from packages/cli/src/commands/hydrogen/dev.ts

HOW to test your changes?

  1. Run shopify hydrogen dev in the templates/skeleton folder
  2. You should no longer see the error

Note** this will require you to test this hydrogen-cli change with the Shopify CLI local override workaround

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Removes the React Router v7 version check from the dev command as it was
not accurately checking what is resolved in node_moduels
@andguy95 andguy95 requested a review from a team as a code owner February 24, 2026 23:52
@shopify
Copy link
Contributor

shopify bot commented Feb 24, 2026

Oxygen deployed a preview of your an-removes-rr7-warn branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202611:53 PM

Learn more about Hydrogen's GitHub integration.

'@shopify/cli-hydrogen': patch
---

Removes the React Router v7 version check from the dev command as was confusing from what was resolved in node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nittiest of nits: this will be read by people after the change has been made

write it in the past form when possible: "Removes" → "Removed", or even "No longer warn about react router versions when starting the dev server"

Copy link
Contributor

@fredericoo fredericoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit on the changesets but it’s great!

@andguy95 andguy95 merged commit dee7f13 into main Feb 25, 2026
15 checks passed
@andguy95 andguy95 deleted the an-removes-rr7-warn branch February 25, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants