Conversation
Removes the React Router v7 version check from the dev command as it was not accurately checking what is resolved in node_moduels
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
kdaviduik
approved these changes
Feb 25, 2026
fredericoo
reviewed
Feb 25, 2026
| '@shopify/cli-hydrogen': patch | ||
| --- | ||
|
|
||
| Removes the React Router v7 version check from the dev command as was confusing from what was resolved in node_modules |
Contributor
There was a problem hiding this comment.
nittiest of nits: this will be read by people after the change has been made
write it in the past form when possible: "Removes" → "Removed", or even "No longer warn about react router versions when starting the dev server"
fredericoo
approved these changes
Feb 25, 2026
Contributor
fredericoo
left a comment
There was a problem hiding this comment.
just a nit on the changesets but it’s great!
Merged
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The React Router v7 version check was generating inaccurate warnings during shopify hydrogen dev because it was not correctly checking what was actually resolved in node_modules. This caused confusion for developers who had valid React Router installations but were still seeing version mismatch warnings.
WHAT is this pull request doing?
Removes the React Router v7 version compatibility check from the Hydrogen dev command:
HOW to test your changes?
shopify hydrogen devin thetemplates/skeletonfolderNote** this will require you to test this
hydrogen-clichange with the Shopify CLI local override workaroundChecklist