test(e2e): add combined-listings recipe e2e tests#3544
Open
itsjustriley wants to merge 8 commits intorecipe-test-bundlesfrom
Open
test(e2e): add combined-listings recipe e2e tests#3544itsjustriley wants to merge 8 commits intorecipe-test-bundlesfrom
itsjustriley wants to merge 8 commits intorecipe-test-bundlesfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
2bf6cfa to
0aada99
Compare
6fbb0ab to
51e560f
Compare
5 tasks
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ 1 findings → ✅ No issues → ✅ No issues → ✅ No issues |
fredericoo
reviewed
Mar 6, 2026
fredericoo
reviewed
Mar 6, 2026
fredericoo
reviewed
Mar 6, 2026
kdaviduik
previously requested changes
Mar 10, 2026
07c2c55 to
6314196
Compare
ad9efb6 to
33aded1
Compare
6314196 to
a55fc97
Compare
Change absence testing from .not.toBeVisible() to .toHaveCount(0) for more robust validation following gift card test patterns. Also simplify price range absence test to use getByText directly.
33aded1 to
c5e7e6d
Compare
43595df to
c6ce812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds e2e test coverage for the combined-listings recipe, which enables displaying and managing combined listings created with the Shopify Combined Listings app. This continues the systematic testing of recipes to ensure all user-facing changes are validated.
This PR is stacked on #3543 (bundles tests).
WHAT is this pull request doing?
Adds
e2e/specs/recipes/combined-listings.spec.tswith 6 tests covering:Tests use role-based selectors,
.toHaveCount(0)for robust absence testing, and follow established patterns from existing recipe tests.The combined-listings recipe allows grouping separate products together into a single product listing using a shared option like color or size. Parent products are hidden from collection listings by default.
HOW to test your changes?
All tests pass (25 total: 6 bundles + 6 combined-listings + 7 infinite-scroll + 6 markets).
Checklist