Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This comment has been minimized.
This comment has been minimized.
lucyxiang
changed the title
lucyxiang
changed the title
fredericoo
previously requested changes
Apr 1, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
needs changeset
can i ask you to elaborate on what this does or what issue it fixes? ◡̈
Contributor
Author
|
Does it need a changeset? IMO this change is not |
lucyxiang
force-pushed
the
04-01-add_error_handling_for_hydrogenstorefronts_access_denial
branch
from
ba993f7 to
e5b299d
Compare
kdaviduik
reviewed
Apr 1, 2026
lucyxiang
force-pushed
the
04-01-add_error_handling_for_hydrogenstorefronts_access_denial
branch
from
e5b299d to
fb01d94
Compare
andguy95
reviewed
Apr 1, 2026
lucyxiang
force-pushed
the
04-01-add_error_handling_for_hydrogenstorefronts_access_denial
branch
from
fb01d94 to
afa2a4c
Compare
kdaviduik
reviewed
Apr 1, 2026
kdaviduik
approved these changes
Apr 1, 2026
kdaviduik
deleted the
04-01-add_error_handling_for_hydrogenstorefronts_access_denial
branch
Merged
itsjustriley
added a commit
that referenced
this pull request
Apr 9, 2026
Adds the changelog entry for the 2026.1.4 release to enable `h2 upgrade` CLI detection. Key changes in this release: - Storefront MCP proxy for AI agent integration (PR #3572) - useCustomAuthDomain opt-out for custom HTTPS/ngrok setups (PR #3642) - GraphQL access denied errors handled as user errors (PR #3654) - vite bumped to ^6.4.2 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
itsjustriley
added a commit
that referenced
this pull request
Apr 9, 2026
* chore: update changelog.json for 2026.1.4 Adds the changelog entry for the 2026.1.4 release to enable `h2 upgrade` CLI detection. Key changes in this release: - Storefront MCP proxy for AI agent integration (PR #3572) - useCustomAuthDomain opt-out for custom HTTPS/ngrok setups (PR #3642) - GraphQL access denied errors handled as user errors (PR #3654) - vite bumped to ^6.4.2 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: improve changelog.json entries for 2026.1.4 The original entries had several merchant-clarity issues caught in review: - MCP proxy entry lacked actionable setup guidance (no endpoint URL, no docs link). Added /api/mcp path example and link to shopify.dev/docs/apps/build/storefront-mcp/servers/storefront. - Same entry conflated the new MCP feature with the unrelated GraphQL route file cleanup. The route deletion stems from proxyStandardRoutes (December 2025), not MCP. Separated with "Separately..." sentence. - useCustomAuthDomain entry now leads with the merchant's situation ("If you use a custom HTTPS domain...") for easier scanning. - GraphQL access denied fix reworded from internal monitoring framing to merchant-facing language. - Added missing fix entry for PR #3672 (@xstate/fsm bundling regression from 2026.1.3 — vite.config.ts change had no changeset requirement but fix is user-visible in strict pnpm setups). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: trim changelog.json entries to match established verbosity pattern Previous changelog entries use 1-2 concise sentences. The MCP proxy and useMachine entries were substantially longer. Trimmed both: - MCP proxy: dropped docs link, dev URL example, and route cleanup note (the proxy conflation concern is resolved by simply not mentioning GraphQL at all) - useMachine fix: dropped Vite implementation details; the merchant action is clear from a single sentence Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Don't send user GraphQL permission (access denied) errors to observe (~1k events/ last 30 days). Observe should only have bug/ actionable errors
https://observe.shopify.io/a/observe/errors/12590085769547859575?r={"from"%3A"now-30d"%2C"to"%3A"now"}&tz=browser&f={"resource.service.name"%3A["cli"]%2C"slice_name"%3A["hydrogen"]}
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist