esify should not try to convert .js.erb files into ASTs

[GoodForOneFare]

In global-reference-to-import, findDeclaringFile is returning .js.erb files. findNamedExports then attempts to parse those with jscodeshift.

e.g.,:

• admin/modules/mixins/date_handler.coffee contains a reference to Shopify.DateRangeDb.
• DateRangeDb is exposed by admin/date_range_db.js.erb

Affects 50+ files in admin; probably many more outside that.

[GoodForOneFare]

@justinthec the .js.erb files are providing useful context, so we can't just ignore them. I think you created a proof of concept for non-jscodeshift export discovery, so maybe we can just drop that in to fix this?

[justinthec]

I could switch the searching strategy based on the file extension. .js --> AST, .js.erb --> ag regex search. Are there any other js file extensions to know about?

[GoodForOneFare]

I'd assume that any file type within app/assets/javascripts has the potential to show up in search results (sidenote: which probably means its pointlessly sifting through a bunch of node_modules folders).

I'm not sure if two code paths for this is worth it. Was the difference in performance that large?

[justinthec]

The difference was about 50 ms

[GoodForOneFare]

If the code is already written, then let's go with two code paths.

[GoodForOneFare]

Can we get this fixed soon? It's not going to be a good experience for anyone trying to use esify right now.

[justinthec]

I will get the PR up tonight.