Skip to content

Automatically import Twine for Bindings #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouk merged 2 commits into from
Jun 24, 2016
Merged

Automatically import Twine for Bindings #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7194696
Automatically import Twine for Bindings
bouk Jun 23, 2016
302459a
Bindings -> Twine
bouk Jun 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/esify/lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ module.exports = function loadConfig() {
NProgress: 'NProgress',
FastClick: 'shopify-fastclick',
Clipboard: 'clipboard',
Twine: 'twine',
Bindings: 'twine',
},
renameIdentifiers: {
jQuery: '$',
Bindings: 'Twine',
Copy link
Contributor Author

@bouk bouk Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemonmade also added this

Copy link
Member

@lemonmade lemonmade Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shopify/tnt are we cool with moving back to Twine as the main name for accessing Twine (over Bindings)?

Copy link

@tsov tsov Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should 🔥 Bindings

Copy link
Member

@lemonmade lemonmade Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

},
renameProperties: {
_: {
Expand Down