Conversation
| // Requires that functions have return type annotation. | ||
| 'flowtype/require-return-type': ['warn', 'always', {annotateUndefined: 'never'}], | ||
| // Makes sure that files have a valid @flow annotation. | ||
| 'flowtype/require-valid-file-annotation': 'warn', |
Contributor
There was a problem hiding this comment.
can we delete our plugin now that this exists?
Member
Author
There was a problem hiding this comment.
Good call. I think I am also going to turn off the required types for return/ parameter, generally I think inference is better and less overbearing. Let me know if you think that's a bad idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all of our ESLint-related dependencies, including bumping ESLint to 3.x. It also adds a test to make sure that we configure every available rule, and adds some missing rules as a result of that. Here are some highlights:
while (true) {}Thoughts? @bouk @GoodForOneFare @Shopify/fed