Skip to content

Update dependencies#205

Merged
lemonmade merged 5 commits intomasterfrom
update-dependencies
Jul 20, 2016
Merged

Update dependencies#205
lemonmade merged 5 commits intomasterfrom
update-dependencies

Conversation

@lemonmade
Copy link
Member

@lemonmade lemonmade commented Jul 15, 2016

This PR updates all of our ESLint-related dependencies, including bumping ESLint to 3.x. It also adds a test to make sure that we configure every available rule, and adds some missing rules as a result of that. Here are some highlights:

  • I reconfigured the "use stateless React components if you can" rule. I don't think there's a reason not to and it's a very good practice I'd like to encourage.
  • Added a bunch of a11y-related ESLint rules
  • Allowed constant conditions for loops, so you can do while (true) {}

Thoughts? @bouk @GoodForOneFare @Shopify/fed

// Requires that functions have return type annotation.
'flowtype/require-return-type': ['warn', 'always', {annotateUndefined: 'never'}],
// Makes sure that files have a valid @flow annotation.
'flowtype/require-valid-file-annotation': 'warn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete our plugin now that this exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I think I am also going to turn off the required types for return/ parameter, generally I think inference is better and less overbearing. Let me know if you think that's a bad idea.

@lemonmade lemonmade merged commit aa77055 into master Jul 20, 2016
@lemonmade lemonmade deleted the update-dependencies branch July 20, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants