Skip to content

Turn off no-duplicate-imports rule #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouk merged 1 commit into from
Sep 7, 2016
Merged

Turn off no-duplicate-imports rule #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin-shopify/lib/config/rules/ecmascript-6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ module.exports = {
'no-const-assign': 'error',
// Disallow duplicate name in class members
'no-dupe-class-members': 'error',
// Disallow duplicate module imports
'no-duplicate-imports': 'error',
// Disallow duplicate module imports (disabled, as import/no-duplicates does the same job but better)
'no-duplicate-imports': 'off',
Copy link
Member

@lemonmade lemonmade Sep 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ I just ran into this and figured I was going to have to submit a PR for that rule. Awesome that we already had a better rule in place!

// Disallow use of the new operator with the Symbol object
'no-new-symbol': 'error',
// Disallow to use this/super before super() calling in constructors.
Expand Down