Skip to content

Add legacy CoffeeScript guide#269

Merged
nwtn merged 1 commit intomasterfrom
add-coffeescript
Aug 14, 2018
Merged

Add legacy CoffeeScript guide#269
nwtn merged 1 commit intomasterfrom
add-coffeescript

Conversation

@nwtn
Copy link
Contributor

@nwtn nwtn commented Aug 9, 2018

I’ve been asked to shut down https://github.com/Shopify/CoffeeScript-Style-Guide if it’s not being used. It’s not really but I think we should preserve this content for anybody updating legacy CoffeeScript which still, unfortunately, exists.

Other than the warning at the top, all of this is directly ported from the CofeeScript-Style-Guide repo unchanged.

I know all this stuff is going to eventually get cleaned up and moved elsewhere, but for the time-being this felt like the best home. Lmk if you disagree.

@nwtn nwtn requested a review from lemonmade August 9, 2018 15:24
@lemonmade lemonmade requested review from TzviPM and marutypes August 9, 2018 16:14
@@ -0,0 +1,723 @@
# CoffeeScript Style Guide

Don’t write new CoffeeScript please. Only use this guide if you’re updating existing CoffeeScript and converting is out of scope.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bolt this or something? Or maybe get a small bolded blurb that says something like Note: CoffeeScript is deprecated at Shopify, please do not write any new CoffeeScript files.

@GoodForOneFare
Copy link
Member

The content is still useful, so I'd just leave the repo up ¯\(ツ)

@nwtn
Copy link
Contributor Author

nwtn commented Aug 9, 2018

The content is still useful, so I'd just leave the repo up ¯(ツ)/¯

We’re hitting the limits of the number of private repos we’re allowed on GH and this isn’t worth wasting one on imo, especially since we already have the javascript and web-foundations repos.

@GoodForOneFare
Copy link
Member

Cool. Another option would be making the original repo public via spy / a dev-accel issue.

@nwtn
Copy link
Contributor Author

nwtn commented Aug 13, 2018

Right now it’s basically Yet Another Place for people to have to look to find our docs. I’d prefer doing consolidation if possible, rather than making this lone wolf public.

So, let me approach this another way. Does anybody strongly object to me merging this? If not, I’ll merge and remove the other repo at the end of the day.

@nwtn nwtn force-pushed the add-coffeescript branch from a57e1eb to 1cbde0c Compare August 14, 2018 15:37
@nwtn nwtn merged commit ed15526 into master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants