Add an annotation that skips rollout verification#282
Closed
Conversation
dturn
force-pushed
the
no-mointoring-annotation
branch
from
2631d39 to
550d0f6
Compare
dturn
requested review from
KnVerey and
klautcomputing
and removed request for
KnVerey
klautcomputing
approved these changes
Apr 17, 2018
Contributor
klautcomputing
left a comment
klautcomputing
left a comment
There was a problem hiding this comment.
Looks solid to me and there are tests!
We should try it out somewhere to that we know it works in production.
| end | ||
|
|
||
| def test_restart_failure_can_be_ignored | ||
| success = deploy_fixtures("hello-cloud", subset: ["configmap-data.yml", "web.yml.erb"]) do |fixtures| |
Contributor
There was a problem hiding this comment.
This is my ultimate nitpick: success is what we like, but so far we only know it's a result
Contributor
Author
|
@KnVerey No rush on this, but want to make sure its on your radar |
Update readme and changelog
dturn
force-pushed
the
no-mointoring-annotation
branch
from
114fae7 to
db9c63e
Compare
Contributor
Author
|
We're closing this pr unmerged because it doesn't seem important enough to justify making the state tracking code more cluttered. We have an issue to improve this code, but its not high priority. If this feature becomes high priority we can either bring this back as is or fix up the state tracking and then build this the right way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a resource to skip rollout verification via a new annotation
'kubernetes-deploy.shopify.io/no-rollout-verification'This prevents the deploy from being a failure if the resource fails to deploy, by causing
ResourceWatcherto ignore the resource though it does print a message saying its ignoring the resource.Feature wanted from: #229