Refactor SlaveLag throttler as ReplicaLag#144
Merged
Conversation
driv3r
reviewed
Aug 30, 2023
Sinclert
force-pushed
the
sinclert/refactor-slave-lag-throttler
branch
from
6c1b7a7 to
b59177a
Compare
Sinclert
force-pushed
the
sinclert/refactor-slave-lag-throttler
branch
from
b59177a to
864d7b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the legacy named
SlaveLagthrottler to nowadays terminology (ReplicaLag). To maintain compatibility with existing applications, this throttler can be selected using any of the following values:replica_lag_throttler(new).slave_lag_throttler(deprecated).Notes
Given this gem still supports MySQL 5.7, there are certain MySQL commands which could not be refactored:
SHOW SLAVE STATUScommand (reference).START / STOP SLAVEcommands (reference).GRANT REPLICATION SLAVEcommand (reference).--log-slave-updatesconfig option (reference).