Handle composite primary keys with line breaks#164
Merged
coding-chimp merged 2 commits intomasterfrom Jul 23, 2024
Merged
Conversation
coding-chimp
force-pushed
the
bb/primary-key-with-line-breaks
branch
from
290146a to
d753bbf
Compare
mtaner
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've encountered problems with composite primary keys, including varchar columns with values that have line breaks. The regex used to ignore primary key duplicate warnings can't handle the line breaks, which leads to LHM aborting completely safe migrations.
This PR rejiggers the warning matching to avoid this.