Make backup reduction available to all throttlers#172
Merged
coding-chimp merged 3 commits intomasterfrom Aug 21, 2024
Merged
Conversation
coding-chimp
force-pushed
the
bb/backup-reduction-fix
branch
3 times, most recently
from
82bd38d to
c3e5e08
Compare
coding-chimp
force-pushed
the
bb/backup-reduction-fix
branch
from
c3e5e08 to
55e36a8
Compare
mtaner
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing #165, I missed that it was only implemented for the time throttler and would crash if you use any other throttler.
So, I'm moving the functionality into a module and am including that in every built-in throttler. We skip the error handling entirely if a user uses a custom throttler that does not yet include functionality.