Cleanup tables after each test#48
Merged
Merged
Conversation
bbuchalter
requested review from
ajmaidak,
berlincount,
insom and
jordanwheeler
| cleanup_connection = new_mysql_connection | ||
| results = cleanup_connection.query("SELECT table_name FROM information_schema.tables WHERE table_schema = '#{$db_name}';") | ||
| table_names_for_cleanup = results.map { |row| "#{$db_name}." + row.values.first } | ||
| cleanup_connection.query("DROP TABLE #{table_names_for_cleanup.join(', ')};") if table_names_for_cleanup.length > 0 |
There was a problem hiding this comment.
DROP TABLE IF EXISTS is always the way to go.
|
i'm a little surprised this doesn't break any existing tests that relied on state leaking 😛 i suppose this beats adding a |
jordanwheeler
approved these changes
Aug 27, 2018
insom
approved these changes
Aug 27, 2018
bbuchalter
force-pushed
the
cleanup_tables_for_each_test
branch
from
ee8eb05 to
2fcb5a1
Compare
bbuchalter
force-pushed
the
cleanup_tables_for_each_test
branch
from
2fcb5a1 to
fad26f8
Compare
ajmaidak
approved these changes
Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46.
This improves test isolation while also setting the stage to address
#47 by shortening the timestamps
in "lhma" tables. Without this cleanup, and without the precision of those
timestamps, tests were failing reporting duplicate table names.
Tophat instructions
See no tables are left after test suite is run.