Loosen dependency on retriable gem#54
Merged
Merged
Conversation
Given: * retries are not configurable from outside the library yet (#53) * Shopify is the primary consumer of this library When: * Shopify cannot currently use retriable >=3 (https://github.com/Shopify/shopify/pull/167954) Then: * You get this PR! The primary feature that we care about from the pre-3.0 release is kamui/retriable#24 which targets subclasses of exceptions. Since we're loosing that, we'll just duplicate the error classes from which we might expect the errors we want to retry.
bbuchalter
force-pushed
the
loosen_retriable_version_dep
branch
from
c909037 to
2c707c3
Compare
berlincount
approved these changes
Sep 3, 2018
insom
approved these changes
Sep 4, 2018
| s.required_ruby_version = '>= 2.3.0' | ||
|
|
||
| s.add_dependency 'retriable', '>= 3.0.0' | ||
| s.add_dependency 'retriable' |
There was a problem hiding this comment.
This seems a tiny bit dangerous, but I suspect if someone is running a ridiculously old retriable they will come to us with errors anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given:
When:
Then:
The primary feature that we care about from the pre-3.0 release is kamui/retriable#24
which targets subclasses of exceptions. Since we're loosing that, we'll just duplicate the error classes from which we might expect the errors we want to retry.