Restore counter behavior in ToSDrop#133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit caf34da (Simplify TestThing to pure drop without call tracking) removed the counter that incremented on each
to_scall. The spec YAML was never regenerated to match the new static behavior, so every spec with'instantiate:ToSDrop:': {foo: N}is off by one — they expect"woot: N+1"but get"woot: N".Restoring the counter is a smaller, more conservative fix than regenerating the ~27 spec entries that depend on it. Counter-based
to_salso has real semantic value: it verifies the filter actually calledto_s, not just that the drop arrived in the template context.The
to_s:variant continues to return its static value as before.