Skip to content

Make sure the run cursor is saved in the job #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Make sure the run cursor is saved in the job #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/jobs/concerns/maintenance_tasks/task_job_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def retry_on(*, **)

def build_enumerator(_run, cursor:)
cursor ||= @run.cursor
self.cursor_position = cursor
@collection_enum = @task.enumerator_builder(cursor: cursor)

@collection_enum ||= case (collection = @task.collection)
Expand Down
11 changes: 11 additions & 0 deletions test/jobs/maintenance_tasks/task_job_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,17 @@ class << self
assert_equal "0", @run.reload.cursor
end

test ".perform_now persists cursor when there's an error" do
run = Run.create!(task_name: "Maintenance::ErrorTask")

TaskJob.perform_now(run)
assert_equal "1", run.reload.cursor

run.enqueued!
TaskJob.perform_now(run)
assert_equal "1", run.reload.cursor
end

test ".perform_now starts job from cursor position when job resumes" do
@run.update!(cursor: "0")

Expand Down