Don't use symbol to denote absence of count method#1464
Merged
etiennebarrie merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
LLMs apparently assume `:no_count` means the Task shouldn't try to calculate the total number of ticks, but it's actually the opposite, :no_count means no explicit count method has been defined, and the total number of ticks should be computed (possibly with an expensive query or processing). This was always meant as an internal sentinel value, and it shouldn't be used by application code. This switches to an sentinel value stored in a private constant, which thanks to nested modules is easily accessible, but not so from application code.
adrianna-chang-shopify
approved these changes
May 4, 2026
etiennebarrie
deleted the
dont-use-symbol-to-denote-absence-of-count-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMs apparently assume
:no_countmeans the Task shouldn't try to calculate the total number of ticks, but it's actually the opposite, :no_count means no explicit count method has been defined, and the total number of ticks should be computed (possibly with an expensive query or processing).This was always meant as an internal sentinel value, and it shouldn't be used by application code.
This switches to an sentinel value stored in a private constant, which thanks to nested modules is easily accessible, but not so from application code.