Maintain backwards compatibility when using #has_one_attached #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling Run#has_one_attached
adrianna-chang-shopify
force-pushed
the
fix-activestorage-incompatibility
branch
from
8d864ae to
9057701
Compare
etiennebarrie
approved these changes
Mar 29, 2021
Merged
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
…ling Run#has_one_attached (Shopify#385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.2.0is broken for all Rails versions < 6.1.0 due tohas_one_attached: unknown keyword: service (ArgumentError), introduced in this PR.Couldn't think of a better way to patch this and preserve functionality for Rails < 6.1.0 while allowing service configuration for Rails 6.1+ apps than checking the kwargs on the method and either passing in a service or not 😅 Let me know if you can think of a better way!Opting instead to check for the presence of the
MaintenanceTasks.active_storage_serviceconfig instead to check if we should specify theservicekwarg, rather than doing parameter introspection.I think we may also want to expand our test suite to test against a dummy app that use Rails 6.0, and then Rails 6.1 to make sure we catch things like this moving forward.
🎩
has_one_attached: unknown keyword: service (ArgumentError)should be raised