Allow backoff to be specified via a proc#547
Merged
adrianna-chang-shopify merged 2 commits intomainfrom Dec 7, 2021
Merged
Conversation
nvasilevski
approved these changes
Dec 6, 2021
adrianna-chang-shopify
force-pushed
the
backoff-as-proc
branch
from
6b84153 to
f2794db
Compare
etiennebarrie
approved these changes
Dec 7, 2021
Member
etiennebarrie
left a comment
etiennebarrie
left a comment
There was a problem hiding this comment.
Just a tiny proposition to tweak the place we check for call.
adrianna-chang-shopify
force-pushed
the
backoff-as-proc
branch
from
11f3eb9 to
c442444
Compare
adrianna-chang-shopify
force-pushed
the
backoff-as-proc
branch
from
c442444 to
bf01760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow backoff to be provided via a callable object, rather than requiring a hardcoded
ActiveSupport::Duration. This allows the backoff to be computed when the enumerator is being built, rather than being assigned when the task code is loaded.This will facilitate removing some of the custom throttle enumerator usage in
Shopify/shopify, allowing us to define the throttle conditions directly on a base task class.