correctly handle Float::INFINITY

[elfassy]

closes #276

Why

Infinity was never explicitly supported by the money gem, yet was not raising, creating issues like #276

Also some code tries to compare a money object with Infinity, which results in exceptions for currencies with no decimals like JPY, ex:

objects.sort_by{|object| object.price || Float::INFINITY}

What

• explicitly remove support for Money.new(Float::INFINITY)
• allow comparing a money object with Float::INFINITY

Before

Money.new(1, "JPY") < Float::INFINITY #=> FloatDomainError: Computation results in 'Infinity' (FloatDomainError)
Money.new(Float::INFINITY) #=> no exceptions

After

Money.new(1, "JPY") < Float::INFINITY #=> true
Money.new(Float::INFINITY) #=> raises ArgumentError

[elfassy]

this will also speed up significantly comparing with a Numeric by not casting these to money objects

[JingxianHou]

what's the plan for merging this, once it's merged the existing code that uses infinity will automatically fail in production?

[elfassy]

nothing should be doing Money.new(Infinity) , but if it is, it will be caught by tests before code is merged to prod

[ryanquanz]

All LGTM!

[JingxianHou]

I understand that it will be caught during local development. However if there is already infinity being used in production, does this change breaks those functionalities?

[elfassy]

@JingxianHou yes this is a breaking change for people using Money.new(Infinity). This will be released in a major gem update (v4). If we want we can split this breaking change from fixing the <=> which can also be released in v3, in addition to a deprecation warning

[elfassy]

moved raising to #476