Commit d1981bc
authored
[Layout foundations] Adjust size and position of title and body in SkeletonPage to closer match Page (#8030)
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
### WHY are these changes introduced?
Fixes #8014 <!-- link to issue if one exists -->
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
- Centers `SkeletonTitle` to align with `PrimaryActionSkeleton` on right
- Reduces height of `SkeletonTitle` from `28px` to `24px` to closer
match `Page` title
- Removes `paddingBlockStart` from `SkeletonPage` Body allowing it shift
up vertically matching `Page`
Before|
:----:|
<img width="1007" alt="Screenshot 2023-01-11 at 3 48 06 PM"
src="https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">|
**After**|
<img width="1024" alt="Screenshot 2023-01-11 at 3 47 40 PM"
src="https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">|
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
<!-- ℹ️ Delete the following for small / trivial changes -->
### How to 🎩
[Spin
Link](https://admin.web.web-6ubu.chaz-dean.us.spin.dev/store/shop1/)
<!--
Give as much information as needed to experiment with the component
in the playground.
-->
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide1 parent 40b4d87 commit d1981bc
File tree
2 files changed
+12
-14
lines changed- .changeset
- polaris-react/src/components/SkeletonPage
2 files changed
+12
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 7 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
| 91 | + | |
99 | 92 | | |
100 | 93 | | |
101 | 94 | | |
| |||
0 commit comments