[Layout foundations] Adjust size and position of title and body in SkeletonPage to closer match Page #8030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazdean
requested review from
SeanyB,
johanstromqvist,
kyledurand,
nayeobkim,
sarahill and
yurm04
kyledurand
reviewed
Jan 12, 2023
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
Code looks good but there's no chromatic diff. This needs a changeset entry anyway, can you push one up and see if that kicks off choromatic?
Contributor
size-limit report 📦
|
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @chazdean! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230112154554yarn add @shopify/polaris@0.0.0-snapshot-release-20230112154554 |
sarahill
approved these changes
Jan 12, 2023
chazdean
force-pushed
the
layout-rebuild-batch-2
branch
from
3c4a2a3 to
a5e1013
Compare
johanstromqvist
approved these changes
Jan 12, 2023
chazdean
force-pushed
the
layout-rebuild-batch-2
branch
from
a5e1013 to
40b4d87
Compare
chazdean
force-pushed
the
fix-skeleton-page-layout
branch
from
05b687e to
478a89f
Compare
chazdean
force-pushed
the
fix-skeleton-page-layout
branch
from
478a89f to
9cec9f3
Compare
laurkim
pushed a commit
that referenced
this pull request
Jan 26, 2023
…eletonPage to closer match Page (#8030) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #8014 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Centers `SkeletonTitle` to align with `PrimaryActionSkeleton` on right - Reduces height of `SkeletonTitle` from `28px` to `24px` to closer match `Page` title - Removes `paddingBlockStart` from `SkeletonPage` Body allowing it shift up vertically matching `Page` Before| :----:| <img width="1007" alt="Screenshot 2023-01-11 at 3 48 06 PM" src="https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">| **After**| <img width="1024" alt="Screenshot 2023-01-11 at 3 47 40 PM" src="https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">| <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 [Spin Link](https://admin.web.web-6ubu.chaz-dean.us.spin.dev/store/shop1/) <!-- Give as much information as needed to experiment with the component in the playground. --> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
![https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">|](https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">|){kind=link}
![https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">|](https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">|){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8014
WHAT is this pull request doing?
SkeletonTitleto align withPrimaryActionSkeletonon rightSkeletonTitlefrom28pxto24pxto closer matchPagetitlepaddingBlockStartfromSkeletonPageBody allowing it shift up vertically matchingPageHow to 🎩
Spin Link
🎩 checklist
README.mdwith documentation changes