Missing Dependency When Running Example Typescript App

[fiveNinePlusR]

Issue summary

Basically an copy of this issue #3130 except it happens from a fresh pull of the master branch of this repository and in one of the example apps. It's possible some of the other example apps have this issue as well.

Expected behavior

cd examples/create-react-app-ts-react-testing/

yarn install or npm install

yarn start or npm run should start the server without an error

Actual behavior

yarn start and npm run both error with the following:

./node_modules/@shopify/polaris/dist/styles.css (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-3-1!./node_modules/postcss-loader/src??postcss!./node_modules/@shopify/polaris/dist/styles.css) Error: Cannot find module '@shopify/browserslist-config' Require stack: - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/browserslist/node.js - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/browserslist/index.js - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/postcss-browser-comments/index.cjs.js - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/postcss-normalize/index.cjs.js - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/react-scripts/config/webpack.config.js - /Users/testuser/project/examples/polaris-react/examples/create-react-app-ts-react-testing/node_modules/react-scripts/scripts/start.js at Array.reduce ()

Steps to reproduce the problem

1. cd examples/create-react-app-ts-react-testing/
2. yarn install
3. yarn start or npm run should start the server without an error
4. browse localhost:3000

Reduced test case

the example app examples/create-react-app-ts-react-testing/ in the repo

Specifications

• Are you using the React components? (Y/N): Y
• Polaris version number:
  ├─ @shopify/polaris-icons@3.12.0
  ├─ @shopify/polaris-tokens@2.12.3
  ├─ @shopify/polaris@5.0.0
  │ ├─ @shopify/polaris-icons@^3.10.0
  │ ├─ @shopify/polaris-tokens@^2.12.3
• Browser: Firefox
• Device: Mac
• Operating System: macOS

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

[BPScott]

This was fixed in #3132 which was released as part of v5.1.0. We just need to update the examples to use a newer version of @shopify/polaris.

[harismh]

FYI: This same issue happens in the create-react-app example as well. Running yarn install && yarn start yields:

Failed to compile.

./node_modules/@shopify/polaris/dist/styles.css (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-3-1!./node_modules/postcss-loader/src??postcss!./node_modules/@shopify/polaris/dist/styles.css)
Error: Cannot find module '@shopify/browserslist-config'
    at Array.reduce (<anonymous>)

Upping @shopify/polaris in the CRA's package.json from ^5.0.0 to ^5.1.0 fixes the problem. Happy to submit a PR for this if that isn't done already.

[BPScott]

If you want to submit a PR that'd be great, thank you! Can I request that you bump the @shopify/polaris version in all projects in the examples folder. It'd be good to keep them all in sync.

[harismh]

@BPScott Done: #3362

Don't think this warrants any changelog updates.