Skip to content

Conversation

@harismh
Copy link
Contributor

@harismh harismh commented Oct 2, 2020

WHY are these changes introduced?

Fixes #3334 using the dependency version from #3130

WHAT is this pull request doing?

Fresh builds of the create-react-app and create-react-app-ts examples were broken and yielded the following error:

Failed to compile.

./node_modules/@shopify/polaris/dist/styles.css (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-3-1!./node_modules/postcss-loader/src??postcss!./node_modules/@shopify/polaris/dist/styles.css)
Error: Cannot find module '@shopify/browserslist-config'
    at Array.reduce (<anonymous>)

Bumping up @shopify/polaris from 5.0.0 to 5.1.0 resolves this. At the suggestion of @BPScott, all of the example apps were synced and their yarn.locks were rebuilt. All example builds are working now.

Summary of the changes committed

  • Run yarn in the repository root
  • Bump up Polaris to 5.1.0 in examples/create-react-app, /create-react-app-ts-react-testing, /next-js, and /webpack.
  • Run yarn and rebuild yarn.lock in examples
  • Test new builds locally

@ghost
Copy link

ghost commented Oct 2, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you for doing this for us!

@BPScott BPScott added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 2, 2020
@BPScott BPScott merged commit 31ab9a1 into Shopify:master Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

🎉 Thanks for your contribution to Polaris React!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Dependency When Running Example Typescript App

2 participants