-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[a11y] Docs for checkbox, radio button, and choice list #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content, I like how it puts the developer in the merchant's shoes. Just a couple of comments for me!
Co-Authored-By: dpersing <devon.persing@shopify.com>
Thanks for the keen eyeballs, @kaelig! 😁Tweaks made. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
WHY are these changes introduced?
Adds accessibility guidance for the checkbox, radio button, and choice list components, to appear in
polaris-react
docs and in the style guide. The choice list documentation points readers to the other components.WHAT is this pull request doing?
README.md
README.md
README.md
UNRELEASED.md
How to 🎩
master
frompolaris-styleguide
polaris-react
and run the instructions for testing in a consuming project.polaris-styleguide
tab, rundev up && dev start
.Screenshots
Choice list (web)
Checkbox (web)
Radio button (web)