Skip to content

Conversation

dpersing
Copy link

@dpersing dpersing commented Mar 8, 2019

WHY are these changes introduced?

Adds accessibility guidance for the checkbox, radio button, and choice list components, to appear in polaris-react docs and in the style guide. The choice list documentation points readers to the other components.

WHAT is this pull request doing?

  • Adds accessibility documentation for the checkbox README.md
  • Adds accessibility documentation for the radio button README.md
  • Adds accessibility documentation for the choice list README.md
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props:

Screenshots

Choice list (web)

Choice list web documentation

Checkbox (web)

Checkbox web documentation

Radio button (web)

Radio button web documentation

@BPScott BPScott temporarily deployed to polaris-react-pr-1145 March 8, 2019 01:38 Inactive
Copy link
Contributor

@kaelig kaelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content, I like how it puts the developer in the merchant's shoes. Just a couple of comments for me!

Co-Authored-By: dpersing <devon.persing@shopify.com>
@BPScott BPScott temporarily deployed to polaris-react-pr-1145 March 8, 2019 15:06 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1145 March 8, 2019 15:07 Inactive
@dpersing
Copy link
Author

dpersing commented Mar 8, 2019

Thanks for the keen eyeballs, @kaelig! 😁Tweaks made. 🎉

Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants