Revert "[PositionedOverlay] Add scroll support for all scroll containers" #11659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/snapit |
kyledurand
approved these changes
Feb 27, 2024
kushp
approved these changes
Feb 27, 2024
kdaviduik
approved these changes
Feb 27, 2024
sophschneider
force-pushed
the
revert-11399-sophie/popover-scroll-fix
branch
from
525a96e to
dfdb2fb
Compare
Merged
sophschneider
pushed a commit
that referenced
this pull request
Feb 27, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.19.2 ### Patch Changes - [#11659](#11659) [`0371de812`](0371de8) Thanks [@sophschneider](https://github.com/sophschneider)! - Revert `PositionedOverlay` scroll container fix ## polaris.shopify.com@0.63.4 ### Patch Changes - Updated dependencies \[[`0371de812`](0371de8)]: - @shopify/polaris@12.19.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…ers" (Shopify#11659) Reverts Shopify#11399 Reverting because of some issues with the store switcher. Will remerge when we fix the bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11399
Reverting because of some issues with the store switcher. Will remerge when we fix the bugs