Upgrade stylelint-polaris to stylelint v16
#12337
Conversation
|
/snapit |
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240705202418",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240705202418" |
aaronccasanova
requested review from
alex-page,
jesstelford,
kyledurand and
sam-b-rose
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
Looks good. I'd like to revert the max class / combinators / compound selectors and specificity if possible because the css is already too complex IMO but that can be a follow up
| 'selector-max-class': 5, | ||
| 'selector-max-combinators': 5, | ||
| 'selector-max-compound-selectors': 5, | ||
| 'selector-max-specificity': '0,5,0', |
There was a problem hiding this comment.
I'm concerned about these changes but I understand the need to ship this PR and how difficult it would be to refactor the css to make these tests pass. @jesstelford did you try just block disabling the rules here? Would that be possible?
…`stylelint-scss`
…it from 0,2,0 to 0,5,0
It is not forwards compatible with new CSS features. See: stylelint/stylelint#7630
…ing limit from 3 to 5
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
aaronccasanova
force-pushed
the
upgrade-stylelint-polaris
branch
from
7f13243 to
c003716
Compare
|
/snapit |
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240708173140",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240708173140" |
This reverts commit b2d2da4.
This reverts commit b2d2da4.
5 participants
WHAT is this pull request doing?
This PR upgrades
stylelint-polaristostylelintv16 and drops support for v15 and v16.As part of this upgrade, the following updates were made:
stylelintto^16.6.1stylelint-scssto^6.3.2@shopify/eslint-pluginto^45.0.0@shopify/stylelint-pluginto^14.0.0eslintto^8.56.0jest-preset-stylelintto^7.0.1prettierto^3.2.2stylelintto report errors on async rules. See Stylelint issue for more details: Fixstylelint.utils.checkAgainstRule()for Promise-based rules stylelint/stylelint#7820--experimental-vm-modulesflag tojestcalls to enable support for async pluginsstylelint-polarisplugins andstylelintAPIs to be asynchronousprettier.formatcalls to be asynchronouseslintandstylelintfailures after dependency upgradesstyles-insert-stylelint-disablemigration asresult.messagesnodes are now detached from therootAST. Calls such asnode.prev()andnode.before(comment)now throw exceptions as the reported nodes don't have access to properties and methods previously exposed. The consensus speaking with @kyledurand and @sophschneider is that we can revisit adding support for this migration if and when it is needed again.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes